Review Board 1.0.8

Fixing the default selection of "allow web submits" - now with tests

Updated 5 months ago

Mike Conley Reviewers
branches/release_0.6 markus_developers
580
None MarkUs Source Code Repository 
I've picked up where Severin left off here:  http://review.markusproject.org/r/360/ .  Strange that I couldn't just update his diff... *shrug*.

Just wrote two small regression tests.  It's nice to code again.  :)


Manually tested to ensure that it works as advertised.  All unit and functional tests are passing.
Ship it!
Joseph Mate
Posted 5 months ago (February 26th, 2010, 12:25 a.m.)
Looks good. Awesome working remembering the MarkusConfigurator.
Ship it!
Robert Burke
Posted 5 months ago (February 26th, 2010, 7:14 a.m.)
Looks fine to me as well.
Ship it!
Severin Gehwolf
Posted 5 months ago (February 26th, 2010, 8:36 a.m.)
Excellent! Works fabulously :-)
Nice! I didn't know this "assigns" thing. Neat!
  1. On second thought, this might be easier to read:

assignment = assigns(:assignment)
assert assignment.allow_web_submits == true

and

assignment = assigns(:assignment)
assert assignment.allow_web_submits == false

I'm pointing this out, because it confused me what "assigns" does/is. Feel free to keep/change :-)
  2. Good idea, thanks.  Fixed and committed.