Review Board 1.0.8

Ticket #598: Refactored calculate_total_mark method in grade_entry_form.rb

Updated 5 months ago

Farah Juma Reviewers
markus_developers
598
None MarkUs Source Code Repository
Mike suggested refactoring the calculate_total_mark method in grade_entry_form.rb. I've modified it to use the "sum" method instead of manually calculating the total mark.
I ran the functional tests and unit tests and there are no failures or errors. I also tested things manually to make sure the total mark is still getting calculated correctly.
Ship it!
Posted 5 months ago (February 23rd, 2010, 7:45 p.m.)
Love it. So much simpler. Here is my thumbs up :-)
Ship it!
Posted 5 months ago (February 24th, 2010, 3:35 a.m.)
Just found "sum" is defined by ActiveRecord. So nice!
Ship it!
Posted 5 months ago (February 24th, 2010, 10 a.m.)
Farah:

Fantastic work!  And I think we got a performance win in there too.  :)

-Mike