Make "external submits only" a per assignment setting as compared to per course
Updated 2 years, 1 month ago
| Severin Gehwolf | Reviewers | ||
| trunk | markus_developers | ||
| 374 | |||
| None | MarkUs Source Code Repository | ||
In the past it was not possible to allow submissions via the web interface for one assignment and disallow web submissions for others. This has now been implemented.
added required fixture fields and changed assignment_test.rb rake test:units passes with 0 errors, 0 failures
Diff revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
- trunk/app/controllers/assignments_controller.rb:
- trunk/app/models/assignment.rb:
- trunk/app/models/group.rb:
- trunk/app/views/assignments/_form.html.erb:
- trunk/config/environments/development.rb:
- trunk/config/locales/en.yml:
- trunk/db/schema.rb:
- trunk/db/migrate/20091123000907_add_allow_web_submits_field_to_assignments_table.rb:
- trunk/db/populate/04_assignments.rb:
- trunk/lib/markus_configurator.rb:
- trunk/lib/tasks/populate.rake:
- trunk/test/fixtures/assignments.yml:
- trunk/test/functional/assignments_controller_test.rb:
- trunk/test/unit/assignment_test.rb:
- trunk/test/unit/group_test.rb:
Expand changes
Hide Extra Whitespace| trunk/app/controllers/assignments_controller.rb | |||
|---|---|---|---|
| Revision 1085 | New Change | ||
| ... | 98 lines hidden [Expand] | ||
def edit |
|||
| 99 |
# Called when form for creating a new assignment is submitted
|
99 |
# Called when form for creating a new assignment is submitted
|
| 100 |
def new |
100 |
def new |
| 101 |
@assignments = Assignment.all |
101 |
@assignments = Assignment.all |
| 102 |
@assignment = Assignment.new |
102 |
@assignment = Assignment.new |
| 103 |
@assignment.build_submission_rule |
103 |
@assignment.build_submission_rule |
| 104 | #@assignment.assignment_files.build |
104 | |
| 105 |
if !request.post? |
105 |
if !request.post? |
| 106 |
# set default value if web submits are allowed
|
||
| 107 |
@assignment.allow_web_submits = markus_config_repository_external_submits_only? |
||
| 106 |
render :action => 'new' |
108 |
render :action => 'new' |
| 107 |
return
|
109 |
return
|
| 108 |
end |
110 |
end |
| 109 | 111 | ||
| 110 |
@assignment.transaction do |
112 |
@assignment.transaction do |
| ... | 247 lines hidden [Expand] | ||
| trunk/app/models/assignment.rb | |
|---|---|
| Revision 1085 | New Change |
| trunk/app/models/group.rb | |
|---|---|
| Revision 1085 | New Change |
| trunk/app/views/assignments/_form.html.erb | |
|---|---|
| Revision 1085 | New Change |
| trunk/config/environments/development.rb | |
|---|---|
| Revision 1085 | New Change |
| trunk/config/locales/en.yml | |
|---|---|
| Revision 1085 | New Change |
| trunk/db/schema.rb | |
|---|---|
| Revision 1085 | New Change |
| trunk/db/migrate/20091123000907_add_allow_web_submits_field_to_assignments_table.rb | |
|---|---|
| New File | |
| trunk/db/populate/04_assignments.rb | |
|---|---|
| Revision 1085 | New Change |
| trunk/lib/markus_configurator.rb | |
|---|---|
| Revision 1085 | New Change |
| trunk/lib/tasks/populate.rake | |
|---|---|
| Revision 1085 | New Change |
| trunk/test/fixtures/assignments.yml | |
|---|---|
| Revision 1085 | New Change |
| trunk/test/functional/assignments_controller_test.rb | |
|---|---|
| Revision 1085 | New Change |
| trunk/test/unit/assignment_test.rb | |
|---|---|
| Revision 1085 | New Change |
| trunk/test/unit/group_test.rb | |
|---|---|
| Revision 1085 | New Change |
- trunk/app/controllers/assignments_controller.rb:
- trunk/app/models/assignment.rb:
- trunk/app/models/group.rb:
- trunk/app/views/assignments/_form.html.erb:
- trunk/config/environments/development.rb:
- trunk/config/locales/en.yml:
- trunk/db/schema.rb:
- trunk/db/migrate/20091123000907_add_allow_web_submits_field_to_assignments_table.rb:
- trunk/db/populate/04_assignments.rb:
- trunk/lib/markus_configurator.rb:
- trunk/lib/tasks/populate.rake:
- trunk/test/fixtures/assignments.yml:
- trunk/test/functional/assignments_controller_test.rb:
- trunk/test/unit/assignment_test.rb:
- trunk/test/unit/group_test.rb:
Other reviews