Review Board 1.0.8

Make "external submits only" a per assignment setting as compared to per course

Updated 7 months, 3 weeks ago

Severin Gehwolf Reviewers
trunk markus_developers
374
None MarkUs Source Code Repository 
In the past it was not possible to allow submissions via the web interface for one assignment and disallow web submissions for others. This has now been implemented.
added required fixture fields and changed assignment_test.rb

rake test:units passes with 0 errors, 0 failures
Allow Web submission picture
Allow Web submission picture
Severin Gehwolf
Posted 8 months, 1 week ago (November 22nd, 2009, 9:23 p.m.)

   

  

   
    
    
   


  




   



    

     
     
    

    

     
FYI: I won't commit this change.

     

  

   
    
    
   


  



    

    

   


  
 




  

 














 

  




 

   Review request changed
   
Updated 8 months, 1 week ago (November 22nd, 2009, 9:24 p.m.)

 

 

  
    

  


  
  
Added the screenshot.


 




  

 













 

  




 

 

  
  
Tara Clark

  
Posted 8 months, 1 week ago (November 24th, 2009, 3:43 p.m.)

 

 

   
Not quite a ship it - my only concern is that there are no functional tests for when this is turned on and off.

   

  

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Tara, I'm afraid, I don't really understand what you mean. What should I test in the assignments controller? If @assignment.allow_web_submits is assigned? I don't know how to test that. I know about should_assign_to, but this is not exactly what we want here, right?
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    I meant, test that you can submit an assignment via the web if @assignment.allow_web_submits==true and that you can't submit one if @assignment.allow_web_submits==false.
    
    
    
   
    3. 

   


  




   



    

     
     
    

    

     
Why are there no assignment fixtures with allow_web_submits set to false?

     

  

   
    
    
   


  



    

    

   


  
 




  

 
















 

  




 

 

  
  
Severin Gehwolf

  
Posted 8 months ago (November 30th, 2009, 11:28 p.m.)

 

 

   

   

  

   
    
    
   


  




   



    

     
     
    

    

     
Tara, for no good reason :-) I'll add one with value false.

     

  

   
    
    
   


  



    

    

   


  
 




  

 














 

  




 

   Review request changed
   
Updated 8 months ago (November 30th, 2009, 11:31 p.m.)

 

 

  

  
  
I have added tests in group_test.rb. Also there is a bit of a controller test in assignment_controller_test.rb.


 




  

 













 

  




 

 

  
Ship it!

  
Mike Conley

  
Posted 7 months, 4 weeks ago (December 1st, 2009, 11:17 p.m.)

 

 

   
Looks good to me!  Great job with this, Severin!

   

  

   
    
    
   


  




  
 




  

 














 

  




 

   Review request changed
   
Updated 7 months, 3 weeks ago (December 8th, 2009, 11:19 p.m.)

 

 

  

  
  
I know, I had a ship it on this, but when I checked rake test:units last there were failing tests. Hence the update. Except for the fixes for rubric_criteria_test.rb and user_test.rb I have the other errors we see here: http://www.markusproject.org/dev/unit_tests_report.txt fixed. Hope nobody else was working on test fixing.

Now I have rake test:units without failures and errors again. If somebody has a chance to look over it, I'd be happy. Thanks!


 




  

 













 

  




 

 

  
  
Severin Gehwolf

  
Posted 7 months, 3 weeks ago (December 8th, 2009, 11:25 p.m.)

 

 

   

   

  

   
    
    
   


  




   



    

     
     

      

       
        

         
          trunk/app/models/grouping.rb
          

           (Diff revision 3)

          
         
        

       
       

        
 


       
      

     

    

    

     
Fix for mark_test.rb

     

  

   
    
    
   


  



    

    

    

     
     

      

       
        

         
          trunk/app/models/user.rb
          

           (Diff revision 3)

          
         
        

       
       

        
 


       
      

     

    

    

     
Fix for mark_test.rb

     

  

   
    
    
   


  



    

    

    

     
     

      

       
        

         
          trunk/test/unit/assignment_test.rb
          

           (Diff revision 3)

          
         
        

       
       

        
 


       
      

     

    

    

     
There was also this weird inheritance error here. There is no AdminMembership class. Hence, the change.

     

  

   
    
    
   


  



    

    

   


  
 




  

 
















 

  




 

 

  
Ship it!

  
Tara Clark

  
Posted 7 months, 3 weeks ago (December 8th, 2009, 11:39 p.m.)

 

 

   
Looks okay to me.

   

  

   
    
    
   


  




   



    

     
     

      

       
        

         
          trunk/app/models/user.rb
          

           (Diff revision 3)

          
         
        

       
       

        
 


       
      

     

    

    

     
Don't you have this change in another changeset?

     

  

   
    
    
   


  



    

    

   


  
 




  

 


















 

  




 

 

  
  
Severin Gehwolf

  
Posted 7 months, 3 weeks ago (December 8th, 2009, 11:46 p.m.)

 

 

   

   

  

   
    
    
   


  




   



    

     
     

      

       
        

         
          trunk/app/models/user.rb
          

           (Diff revision 3)

          
         
        

       
       

        
 


       
      

     

    

    

     
I do have this in the other review too. My bad. It's the exact same thing, sorry.