Review Board 1.0.8

Next/prev links in Grader now auto-create Submissions if past collection date

Updated 10 months ago

Mike Conley Reviewers
release_0.5 markus_developers
None MarkUs Source Code Repository 
So the next/prev links in the Grader View were only handy if the Submissions had already been created - they would skip over any Groupings that didn't have a Submission at all.

Now, if we're past the collection date, next/prev links will detect whether or not a Submission has been created, and create if necessary.

 

 





  

 













 

  




 

 

  
  
Mike Conley

  
Posted 10 months ago (September 30th, 2009, 2:54 p.m.)

 

 

   

   

  

   
    
    
   


  




   



    

     
     
    

    

     
Remember, I'm using delete_if - that's why the logic seems a bit backwards.  I'm removing the Groupings that we aren't interested in.

     

  

   
    
    
   


  



    

    

   


  
 




  

 














 

  




 

   Review request changed
   
Updated 10 months ago (September 30th, 2009, 3:16 p.m.)

 

 

  

  
  
Moved some of the logic into the Groupings controller.


 




  

 















 

  




 

 

  
Ship it!

  
Severin Gehwolf

  
Posted 10 months ago (September 30th, 2009, 3:23 p.m.)

 

 

   
OK, ship! Let me know when you've committed, so that I can create a patch.

   

  

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Ok, committed.  Can you patch the server so we can show Karen?
    
    
    
   
    2.